Final code formatting and documentation improvements for JSON-LD parser#178
Merged
Conversation
…e/literal_classes
Extracts a common abstract base class, AbstractLineBasedSerializer, from NQuadsSerializer and NTriplesSerializer. This refactoring removes duplicated code for writing statements, values, literals, IRIs, and blank nodes. The new base class centralizes the logic for line-by-line serialization, while subclasses (NQuadsSerializer and NTriplesSerializer) now only need to implement the specific logic for handling contexts (named graphs). - NQuadsSerializer handles the optional context. - NTriplesSerializer ignores the context and logs a warning. This change improves maintainability and reduces code duplication.
…t de la documentation manquante
…le_JSONLD_RDFXML Feature/147 serializer turtle jsonld rdfxml
Test Results760 tests +402 760 ✅ +402 31s ⏱️ +5s Results for commit 9a7caec. ± Comparison against base commit a17f3d6. This pull request removes 358 and adds 760 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the final improvements and documentation updates that were made after the initial merge of the JSON-LD parser feature.
Changes included:
These changes represent important cleanup and quality improvements that should be integrated into the main codebase.
Files modified:
This addresses the final commits that were pending before the initial merge.