Update .pre-commit-config.yaml#331
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 22 22
Lines 2750 2750
=======================================
Hits 2087 2087
Misses 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Apparently there is still a problem with flake8, raising a lot of E231 errors (on strings sent to logging). Strange that this issue does not appeared in #330, and it does not appear when running pre-commit locally, but just when running in git CI 😕 . Hopefully this last version could work fine, despite requiring a small fix in the calib.py (E721) |
jsitarek
approved these changes
Apr 15, 2026
Collaborator
jsitarek
left a comment
jsitarek
left a comment
There was a problem hiding this comment.
looks good to me. Once the automatic tests finish without errors we can merge it.
aleberti
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.