Skip to content

Update .pre-commit-config.yaml #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleberti merged 3 commits into from
Apr 16, 2026
Merged

Update .pre-commit-config.yaml #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ae4335
Update .pre-commit-config.yaml
Elisa-Visentin Apr 14, 2026
de31322
Update calib.py
Elisa-Visentin Apr 14, 2026
02a35e6
messed up parentheses
Elisa-Visentin Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repos:
- id: black-jupyter
# https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html?highlight=other%20tools#flake8
- repo: https://github.com/PyCQA/flake8
rev: 5.0.4
rev: 6.1.0
hooks:
- id: flake8
args: [--max-line-length=88, "--extend-ignore=E203,E712"]
Expand Down
4 changes: 2 additions & 2 deletions magicctapipe/image/calib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ def calibrate(
raise ValueError(
"Check the provided parameters and the telescope type; LST calibration not possible if gamera_geoms not provided"
)
if (not is_lst) and (type(magic_clean[tel_id]) != MAGICClean):
if (not is_lst) and (not isinstance(magic_clean[tel_id], MAGICClean)):
raise ValueError(
"Check the provided magic_clean parameter; MAGIC calibration not possible if magic_clean not a dictionary of MAGICClean objects"
)
if (is_lst) and (type(camera_geoms[tel_id]) != CameraGeometry):
if (is_lst) and (not isinstance(camera_geoms[tel_id], CameraGeometry)):
raise ValueError(
"Check the provided camera_geoms parameter; LST calibration not possible if camera_geoms not a dictionary of CameraGeometry objects"
)
Expand Down
Loading