Skip to content

Add macOS arm64 cross-compilation support - #71

Open
theolivenbaum wants to merge 1 commit into
masterfrom
feat/macos-arm64-cross-compile-15512873457559437727
Open

Add macOS arm64 cross-compilation support#71
theolivenbaum wants to merge 1 commit into
masterfrom
feat/macos-arm64-cross-compile-15512873457559437727

Conversation

@theolivenbaum

Copy link
Copy Markdown
Contributor

This change updates the macOS build pipeline to support cross-compiling the arm64 architecture from an x86_64 macOS runner. It does this by dynamically pulling arm64 bottles from Homebrew via the API/GHCR, extracting them, and passing their paths into the RocksDB make step utilizing EXTRA_CFLAGS/EXTRA_LDFLAGS after doing the standard x86_64 build. We also invoke install_name_tool to ensure runtime links for the arm64 architecture resolve correctly.


PR created automatically by Jules for task 15512873457559437727 started by @theolivenbaum

- Updated `build-native-mac.yaml` to fetch arm64 Homebrew bottles using anonymous GHCR tokens via Python, extracting headers and libraries to a temp dir.
- Extended Azure CLI steps to upload `osx-arm64` libraries.
- Modified `build-rocksdb.sh` to compile `x86_64` and `arm64` consecutively when running on Darwin.
- Supplied paths to the extracted arm64 dependencies using `EXTRA_CFLAGS`, `EXTRA_CXXFLAGS`, and `EXTRA_LDFLAGS`.

Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant