Add macOS arm64 cross-compilation support - #71
Conversation
- Updated `build-native-mac.yaml` to fetch arm64 Homebrew bottles using anonymous GHCR tokens via Python, extracting headers and libraries to a temp dir. - Extended Azure CLI steps to upload `osx-arm64` libraries. - Modified `build-rocksdb.sh` to compile `x86_64` and `arm64` consecutively when running on Darwin. - Supplied paths to the extracted arm64 dependencies using `EXTRA_CFLAGS`, `EXTRA_CXXFLAGS`, and `EXTRA_LDFLAGS`. Co-authored-by: theolivenbaum <8791811+theolivenbaum@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change updates the macOS build pipeline to support cross-compiling the
arm64architecture from anx86_64macOS runner. It does this by dynamically pulling arm64 bottles from Homebrew via the API/GHCR, extracting them, and passing their paths into the RocksDBmakestep utilizingEXTRA_CFLAGS/EXTRA_LDFLAGSafter doing the standardx86_64build. We also invokeinstall_name_toolto ensure runtime links for the arm64 architecture resolve correctly.PR created automatically by Jules for task 15512873457559437727 started by @theolivenbaum