Skip to content

Add macOS arm64 cross-compilation support #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theolivenbaum wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add macOS arm64 cross-compilation support #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions .azure-devops/build-native-mac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,47 @@ steps:
inputs:
script: 'ls -hR /usr/local/'

- task: Bash@3
displayName: 'Download arm64 dependencies'
inputs:
targetType: 'inline'
script: |
cat << 'EOF' > test_fetch_bottle.py
import urllib.request
import json
import os
import tarfile

packages = ["snappy", "zstd", "lz4", "zlib"]
os.makedirs("/tmp/arm64_deps", exist_ok=True)

for pkg in packages:
url = f"https://formulae.brew.sh/api/formula/{pkg}.json"
req = urllib.request.urlopen(url)
data = json.loads(req.read())

bottle_key = next((k for k in data['bottle']['stable']['files'] if 'arm64_' in k), None)
if not bottle_key:
print(f"No arm64 bottle for {pkg}")
continue

bottle_url = data['bottle']['stable']['files'][bottle_key]['url']
print(f"Downloading {pkg} from {bottle_url}")

token_url = f"https://ghcr.io/token?scope=repository:homebrew/core/{pkg}:pull"
token_req = urllib.request.urlopen(token_url)
token = json.loads(token_req.read())['token']

req = urllib.request.Request(bottle_url, headers={'Authorization': f'Bearer {token}'})
tar_path = f"/tmp/arm64_deps/{pkg}.tar.gz"
with urllib.request.urlopen(req) as response, open(tar_path, 'wb') as out_file:
out_file.write(response.read())

with tarfile.open(tar_path, "r:gz") as tar:
tar.extractall(path="/tmp/arm64_deps")
EOF
python3 test_fetch_bottle.py

- task: Bash@3
inputs:
filePath: '$(Build.SourcesDirectory)/build-native/build-rocksdb.sh'
Expand All @@ -46,6 +87,28 @@ steps:
otool -L librocksdb.dylib
# install_name_tool -change /usr/lib/libbz2.1.0.dylib "@loader_path/libbz.dylib" librocksdb.dylib

- task: Bash@3
displayName: 'Adjust dyld links for arm64'
inputs:
targetType: 'inline'
workingDirectory: '$(Build.SourcesDirectory)/build-native/runtimes/osx-arm64/native/'
script: |
otool -L librocksdb.dylib

SNAPPY_PATH=$(otool -L librocksdb.dylib | grep libsnappy | awk '{print $1}')
if [ ! -z "$SNAPPY_PATH" ]; then install_name_tool -change "$SNAPPY_PATH" "@loader_path/libsnappy.dylib" librocksdb.dylib; fi

ZSTD_PATH=$(otool -L librocksdb.dylib | grep libzstd | awk '{print $1}')
if [ ! -z "$ZSTD_PATH" ]; then install_name_tool -change "$ZSTD_PATH" "@loader_path/libzstd.dylib" librocksdb.dylib; fi

Z_PATH=$(otool -L librocksdb.dylib | grep libz.1 | awk '{print $1}')
if [ ! -z "$Z_PATH" ]; then install_name_tool -change "$Z_PATH" "@loader_path/libz.dylib" librocksdb.dylib; fi

LZ4_PATH=$(otool -L librocksdb.dylib | grep liblz4 | awk '{print $1}')
if [ ! -z "$LZ4_PATH" ]; then install_name_tool -change "$LZ4_PATH" "@loader_path/liblz4.dylib" librocksdb.dylib; fi

otool -L librocksdb.dylib

- task: CmdLine@2
displayName: 'list /usr/lib folder after'
inputs:
Expand Down Expand Up @@ -73,6 +136,11 @@ steps:
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f $(Build.SourcesDirectory)/build-native/runtimes/osx-x64/native/librocksdb.dylib --account-name curiosityreleases -c rocksdb -n librocksdb-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f $(Build.SourcesDirectory)/build-native/runtimes/osx-arm64/native/librocksdb.dylib --account-name curiosityreleases -c rocksdb -n librocksdb-arm64-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
Expand Down Expand Up @@ -105,4 +173,28 @@ steps:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f "$(HOMEBREW_CELLAR)/zstd/1.5.7/lib/libzstd.dylib" --account-name curiosityreleases -c rocksdb -n libzstd-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f `find /tmp/arm64_deps -name "libz.1.dylib" -print -quit` --account-name curiosityreleases -c rocksdb -n libz-arm64-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f `find /tmp/arm64_deps -name "liblz4.dylib" -print -quit` --account-name curiosityreleases -c rocksdb -n liblz4-arm64-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f `find /tmp/arm64_deps -name "libsnappy.dylib" -print -quit` --account-name curiosityreleases -c rocksdb -n libsnappy-arm64-v$(ROCKSDBVERSION).dylib --overwrite true'

- task: AzureCLI@1
inputs:
azureSubscription: 'Curiosity GmbH Azure'
scriptLocation: 'inlineScript'
inlineScript: 'az storage blob upload -f `find /tmp/arm64_deps -name "libzstd.dylib" -print -quit` --account-name curiosityreleases -c rocksdb -n libzstd-arm64-v$(ROCKSDBVERSION).dylib --overwrite true'

41 changes: 40 additions & 1 deletion build-native/build-rocksdb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,50 @@ else

echo "----- Build 64 bit --------------------------------------------------"
make clean
CFLAGS="${CFLAGS}" PORTABLE=1 make -j$CONCURRENCY shared_lib || fail "64-bit build failed"

if [ "$(uname)" == "Darwin" ]; then
ORIGINAL_CFLAGS="${CFLAGS}"
ORIGINAL_LDFLAGS="${LDFLAGS}"

CFLAGS="${ORIGINAL_CFLAGS} -arch x86_64"
LDFLAGS="${ORIGINAL_LDFLAGS} -arch x86_64"
fi

CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}" PORTABLE=1 make -j$CONCURRENCY shared_lib || fail "64-bit build failed"
strip librocksdb${LIBEXT}
mkdir -p ../runtimes/${RUNTIME}/native && cp -vL ./librocksdb${LIBEXT} ../runtimes/${RUNTIME}/native/librocksdb${LIBEXT}
mkdir -p ../rocksdb-${ROCKSDBVERSION}/${RUNTIME}/native && cp -vL ./librocksdb${LIBEXT} ../rocksdb-${ROCKSDBVERSION}/${RUNTIME}/native/librocksdb${LIBEXT}

if [ "$(uname)" == "Darwin" ]; then
echo "----- Build arm64 --------------------------------------------------"
make clean

export ZLIB_INCLUDE=$(find /tmp/arm64_deps -type d -name "include" | grep zlib | head -n 1)
export ZLIB_LIB_RELEASE=$(find /tmp/arm64_deps -type f -name "libz.a" | grep zlib | head -n 1)

export LZ4_INCLUDE=$(find /tmp/arm64_deps -type d -name "include" | grep lz4 | head -n 1)
export LZ4_LIB_RELEASE=$(find /tmp/arm64_deps -type f -name "liblz4.a" | grep lz4 | head -n 1)

export SNAPPY_INCLUDE=$(find /tmp/arm64_deps -type d -name "include" | grep snappy | head -n 1)
export SNAPPY_LIB_RELEASE=$(find /tmp/arm64_deps -type f -name "libsnappy.a" | grep snappy | head -n 1)

export ZSTD_INCLUDE=$(find /tmp/arm64_deps -type d -name "include" | grep zstd | head -n 1)
export ZSTD_LIB_RELEASE=$(find /tmp/arm64_deps -type f -name "libzstd.a" | grep zstd | head -n 1)

RUNTIME=osx-arm64
export EXTRA_CFLAGS="-I${ZLIB_INCLUDE} -I${LZ4_INCLUDE} -I${SNAPPY_INCLUDE} -I${ZSTD_INCLUDE} -arch arm64"
export EXTRA_CXXFLAGS="-I${ZLIB_INCLUDE} -I${LZ4_INCLUDE} -I${SNAPPY_INCLUDE} -I${ZSTD_INCLUDE} -arch arm64"
export EXTRA_LDFLAGS="-L$(dirname ${ZLIB_LIB_RELEASE}) -L$(dirname ${LZ4_LIB_RELEASE}) -L$(dirname ${SNAPPY_LIB_RELEASE}) -L$(dirname ${ZSTD_LIB_RELEASE}) -arch arm64"

CFLAGS="${ORIGINAL_CFLAGS} -arch arm64"
LDFLAGS="${ORIGINAL_LDFLAGS} -arch arm64"

CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}" PORTABLE=1 make -j$CONCURRENCY shared_lib || fail "arm64 build failed"
strip librocksdb${LIBEXT}
mkdir -p ../runtimes/${RUNTIME}/native && cp -vL ./librocksdb${LIBEXT} ../runtimes/${RUNTIME}/native/librocksdb${LIBEXT}
mkdir -p ../rocksdb-${ROCKSDBVERSION}/${RUNTIME}/native && cp -vL ./librocksdb${LIBEXT} ../rocksdb-${ROCKSDBVERSION}/${RUNTIME}/native/librocksdb${LIBEXT}
fi

}) || fail "rocksdb build failed"
fi

Expand Down