perf: remove algorithmic compiler and layout cliffs - #2827
Merged
Conversation
Signed-off-by: Alexander Wang <alex@terrastruct.com>
Signed-off-by: Alexander Wang <alex@terrastruct.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
github.com/d2lang/dagro v0.1.1, released from d2lang/dagro#2.What
Why
Removing the JavaScript runtimes exposed several older source-compatible algorithms that repeatedly scanned or copied the entire graph/IR. Large globs, repeated imports, nested containers, style-only boards, and bend-heavy layouts could therefore grow quadratically or worse.
Impact
Apple M4, one CPU, synthetic stress fixtures unless noted:
These are targeted/pathological benchmarks rather than a corpus-weighted claim; ordinary diagrams primarily benefit by avoiding the specific cliffs.
Compatibility
d2liblayout resolvers; CLI/WASM opt in only for stable built-in resolutionValidation
go test ./e2etests -run '^TestE2E$' -count=1 -parallel=1go test -race ./...(all packages except three baseline-confirmed GIF CLI race/timing failures; exact E2E passes under race)go vet ./...GOOS=js GOARCH=wasm go build -trimpath ./d2jsgo mod tidy -diffgo mod verify