perf: optimize deep compound layout - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Deep compound graphs expanded border nodes across every spanned rank, then repeatedly scanned the entire expanded graph for every layer. The inherited algorithm remains interval-sized, but the Go port was also paying avoidable repeated enumeration, allocation, key classification, and validation costs.
Impact
Apple M4, Go 1.25, one benchmark iteration per sample, three samples:
Used by d2lang/d2#2827.
Validation
go test ./... -count=1go test -race ./... -count=1go vet ./...git diff --check