Port D2's sketch surface to Rough.js 4.6.6 - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility scope
The exact contract is D2's sketch-rendering surface:
line,rectangle,ellipse,linearPath,polygon, and SVGpath, using D2's solid and zigzag profiles. Other existing generator APIs remain available for source compatibility, but this PR does not claim every expert Rough.js 4.6.6 option or filler combination is exact.This intentionally changes seeded sketch geometry to the current Rough.js output. It should be released as rough-go v0.2.0 because the output behavior and Go toolchain floor change.
Validation
go vet ./...