You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you have fixed position nodes (fx,fy !== null) that possibly overlap, the collision keeps these nodes fixed and we don't collide with a shadow version at d.x + d.vx, d.y + d.vy
forceCollide jiggles equal positions
0.4397129164975401 0.4397129164975401 - values not strict equal
0.4082309018184576 0.4082309018184576 - values not strict equal
they are 16 decimal places equal, most likely the last bits (1 or 2) of the mantissa are different.
The assert should also compare with a delta.
The test forceCollide jiggles in a reproducible way assumes the random number generator produces the same number sequence for each test. Is this also true if you change the order of the tests?
If I try the modified code it has the same results for the test forceCollide collides nodes as the original code.
It should be because there are no nodes with fixed xy in the test and the modification only does something different for nodes with a fixed x-or-y.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have fixed position nodes (
fx,fy !== null) that possibly overlap, the collision keeps these nodes fixed and we don't collide with a shadow version atd.x + d.vx, d.y + d.vy