[CFX-8118] fix(ci): use bash-completion@2 on macOS smoke runners - #910
[CFX-8118] fix(ci): use bash-completion@2 on macOS smoke runners#910ajalon1 wants to merge 3 commits into
Conversation
Retry Linux apt dependency setup before running smoke tests so transient GitHub-hosted mirror failures do not fail main CI runs. Install bash-completion@2 on macOS to match the CLI completion installer detection and user-facing guidance. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
ajalon1
changed the title
Remove the generic Linux apt retry from the smoke dependency setup. The available CI metadata only showed apt exit 100, not a distinct root cause beyond the existing packages.microsoft.com cleanup. Keep the deterministic macOS fix: install bash-completion@2, matching the CLI completion installer detection and guidance. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
ajalon1
changed the title
|
/approve-smoke-tests |
|
🔐 Fork PR smoke tests triggered by @ajalon1 What happens next:
Warning This PR modifies files under Changed files:
|
| shell: bash | ||
| run: | | ||
| brew install expect bash-completion | ||
| brew install expect bash-completion@2 |
There was a problem hiding this comment.
on ubuntu, apt get bash-completion automatically get bash-completion v2series. brew does not,bash-completiongives usv1`.
Code OwnershipCli Maintainers
Review requested from the teams above. Labels will be removed automatically upon approval. |
|
🔐 Fork smoke tests started by maintainer ⏳ Security scans passed. Running smoke tests... Commit: Warning This PR modifies files under Changed files:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d37612d. Configure here.
| shell: bash | ||
| run: | | ||
| brew install expect bash-completion | ||
| brew install expect bash-completion@2 |
There was a problem hiding this comment.
Composite action change skips PR CI
Low Severity
The composite-action CI rule flags this because callers pin install-deps to @main. This PR's smoke jobs still run the old bash-completion install and never exercise bash-completion@2, so the formula change is unvalidated until after merge.
Triggered by project rule: Bugbot Rules for DataRobot CLI
Reviewed by Cursor Bugbot for commit d37612d. Configure here.
There was a problem hiding this comment.
I know, I know. Will be monitoring post-merge CI once this goes in
|
✅ All smoke tests passed! (Fork PR) ✅ Security Scan: success |
2 participants
RATIONALE
CI smoke jobs after merges to
mainhave been failing before the actual CLI smoke coverage can run. The deterministic issue in this PR is the macOS dependency setup: the smoke action installsbash-completion, while the CLI completion installer detects and recommends Homebrew'sbash-completion@2formula.Related: CFX-8118
CHANGES
bash-completion@2on macOS smoke runners to match CLI completion detection.packages.microsoft.comcleanup.TESTING
ruby -e 'require "yaml"; ... YAML.load_file(...)'for changed YAML filestask buildexpect ./smoke_test_scripts/expect_completion.expwith isolatedHOMEandXDG_CONFIG_HOMEtask lintPR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: The
run-smoke-testslabel won't work. A required Smoke Tests check will block merge until a maintainer acts:/approve-smoke-teststo run smoke tests (results will set the check)/skip-smoke-teststo bypass the check without running testsPlease comment requesting a maintainer review if you need smoke tests to run.
Note
Cursor Bugbot is generating a summary for commit d37612d. Configure here.