Skip to content

[CFX-8118] fix(ci): use bash-completion@2 on macOS smoke runners #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajalon1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CFX-8118] fix(ci): use bash-completion@2 on macOS smoke runners #910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c912b30
fix(ci): stabilize smoke dependency setup
ajalon1 Sep 10, 2026
9c4dcb9
Merge remote-tracking branch 'upstream/main' into aj/fix-ci-build-fai…
ajalon1 Sep 10, 2026
d37612d
fix(ci): scope smoke dependency fix to macos completion
ajalon1 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/install-deps/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ runs:
if: runner.os == 'macOS'
shell: bash
run: |
brew install expect bash-completion
brew install expect bash-completion@2

@ajalon1 ajalon1 Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on ubuntu, apt get bash-completion automatically get bash-completion v2series. brew does not,bash-completiongives usv1`.

@cursor cursor Bot Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composite action change skips PR CI

Low Severity

The composite-action CI rule flags this because callers pin install-deps to @main. This PR's smoke jobs still run the old bash-completion install and never exercise bash-completion@2, so the formula change is unvalidated until after merge.

Fix in Cursor Fix in Web

Triggered by project rule: Bugbot Rules for DataRobot CLI

Reviewed by Cursor Bugbot for commit d37612d. Configure here.

@ajalon1 ajalon1 Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I know. Will be monitoring post-merge CI once this goes in


- name: Install yq
uses: dcarbone/install-yq-action@4075b4dca348d74bd83f2bf82d30f25d7c54539b # v1.3.1
Loading