Skip to content

Fully deprecate the built-in SSH functionality #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolandwalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fully deprecate the built-in SSH functionality #1596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Features
* Let the `--dsn` argument accept literal DSNs as well as aliases.
* Accept `--character-set` as an alias for `--charset` at the CLI.
* Add SSL/TLS version to `status` output.
* Fully deprecate the built-in SSH functionality.


Bug Fixes
Expand Down
4 changes: 2 additions & 2 deletions mycli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1883,8 +1883,8 @@ def get_password_from_file(password_file: str | None) -> str | None:
# ssh_port and ssh_config_path have truthy defaults and are not included
if any([ssh_user, ssh_host, ssh_password, ssh_key_filename, list_ssh_config, ssh_config_host]) and not ssh_warning_off:
click.secho(
"Warning: The built-in SSH functionality is soft deprecated and may be removed in a future release. "
"Please discuss or vote on this at https://github.com/dbcli/mycli/issues/1464",
"Warning: The built-in SSH functionality is deprecated and will be removed in a future release. "
"See Issue https://github.com/dbcli/mycli/issues/1464",
err=True,
fg="red",
)
Expand Down