fix(abi): NFT_PROGRAM_ID pointed at a program that is not deployed on devnet - #372
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks
dcccrypto
force-pushed
the
fix/nft-program-id-devnet
branch
from
August 28, 2026 00:48
5591053 to
ad33cb7
Compare
… devnet The ABI exported NFT_PROGRAM_ID defaulting to FqhKJT9g..., which is the MAINNET address, while every other program id in this SDK is devnet. `solana account FqhKJT9g... -u devnet` returns AccountNotFound, so any consumer importing this constant built transactions against a program that does not exist and failed late and unhelpfully with "Account not found on-chain". percolator-launch already hit this and works around it with its own constant, which documents the symptom verbatim: "made position-NFT mint/burn/transfer fail with Account not found on-chain". Now derived from PROGRAM_IDS_V17.nft rather than carrying an independent literal, so the two cannot drift apart again. The devnet id joins the env-override allowlist; the mainnet id remains allowed for an explicit override. before: NFT_PROGRAM_ID = FqhKJT9gtScjrmfUuRMjeg7cXNpif1fqsy5Jh65tJmTS (not deployed) after: NFT_PROGRAM_ID = CNGBPZRALk9Xu8BdgWNyrLJ7daQ9eJYFf1GnEEC7YCU3 (deployed) Found by the pre-deploy gate harness, which asserts SDK program-id constants against the programs actually on chain. Fixes #371. SDK suite: 968 passed / 31 skipped, unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D
dcccrypto
force-pushed
the
fix/nft-program-id-devnet
branch
from
August 28, 2026 03:35
ad33cb7 to
ae10935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #371.
NFT_PROGRAM_IDdefaulted toFqhKJT9g…— the mainnet address — while every other program id in this SDK is devnet:Any consumer importing it built transactions against a program that does not exist, failing late and unhelpfully with "Account not found on-chain".
percolator-launchalready hit this and works around it with its own constant, documenting the symptom verbatim.Fix: derive from
PROGRAM_IDS_V17.nftinstead of carrying an independent literal, so the two cannot drift apart again. The devnet id joins the env-override allowlist; the mainnet id stays allowed for an explicit override.FqhKJT9g…CNGBPZR…Found by the pre-deploy gate harness, which asserts SDK program-id constants against the programs actually on chain. SDK suite unchanged: 968 passed / 31 skipped.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NgoNgagkvw7i5SSRC3FJ8D