fix: Add model and CLI fields for missing Core One info. - #25
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds new fields (wifi_mac, wifi_ipv4, wifi_ipv6) to the NetworkInfo model to support additional data from the API. The change is straightforward, but it introduces some ambiguity with existing fields. My main feedback is to improve the clarity of the NetworkInfo model by either adding comments or re-organizing the fields for better readability and to avoid confusion for SDK users. As noted in your TODO list, remember to update tests and documentation to reflect these new fields.
| wifi_mac: str | None = None | ||
| wifi_ipv4: str | None = None | ||
| wifi_ipv6: str | None = None |
There was a problem hiding this comment.
While adding these specific wifi_* fields is useful, it introduces ambiguity with the existing generic ipv4, ipv6, and mac fields. It's now unclear what the top-level fields represent (e.g., LAN, WiFi, or the primary active interface), which can be confusing for SDK users. To improve clarity, I recommend adding comments to the NetworkInfo class to explain the purpose of each group of fields (generic, lan_*, and wifi_*).
Additionally, for better readability and consistency, all wifi_* fields should be grouped together. The current placement separates wifi_ssid from the other wifi_ attributes. Consider reordering them to improve code organization.
As a minor improvement, consider ordering the new fields alphabetically.
| wifi_mac: str | None = None | |
| wifi_ipv4: str | None = None | |
| wifi_ipv6: str | None = None | |
| wifi_ipv4: str | None = None | |
| wifi_ipv6: str | None = None | |
| wifi_mac: str | None = None |
|
See #29 for samples |
TODO
chamber, pending getting a sample of the data.Fixes #21