Skip to content

fix: Add model and CLI fields for missing Core One info. - #25

Draft
dcode wants to merge 1 commit into
mainfrom
fix/core-one-fields
Draft

fix: Add model and CLI fields for missing Core One info.#25
dcode wants to merge 1 commit into
mainfrom
fix/core-one-fields

Conversation

@dcode

@dcode dcode commented Mar 10, 2026

Copy link
Copy Markdown
Owner
  • Adds NetworkInfo fields for wifi (mac, ipv4, ipv6).

TODO

  • Add schema support for chamber, pending getting a sample of the data.
  • Update and run tests.
  • Check CLI UI to ensure relevant fields are shown.
  • Update docs where appropriate.

Fixes #21

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the NetworkInfo data model by introducing new fields to capture specific Wi-Fi network details. This change aims to address missing information for Core One devices, ensuring that MAC addresses, IPv4, and IPv6 addresses for Wi-Fi connections are properly stored within the system.

Highlights

  • NetworkInfo Model Update: Added wifi_mac, wifi_ipv4, and wifi_ipv6 fields to the NetworkInfo model to capture comprehensive Wi-Fi details.
Changelog
  • src/prusa/connect/client/models/common.py
    • Added wifi_mac, wifi_ipv4, and wifi_ipv6 fields to the NetworkInfo class.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new fields (wifi_mac, wifi_ipv4, wifi_ipv6) to the NetworkInfo model to support additional data from the API. The change is straightforward, but it introduces some ambiguity with existing fields. My main feedback is to improve the clarity of the NetworkInfo model by either adding comments or re-organizing the fields for better readability and to avoid confusion for SDK users. As noted in your TODO list, remember to update tests and documentation to reflect these new fields.

Comment on lines +37 to +39
wifi_mac: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding these specific wifi_* fields is useful, it introduces ambiguity with the existing generic ipv4, ipv6, and mac fields. It's now unclear what the top-level fields represent (e.g., LAN, WiFi, or the primary active interface), which can be confusing for SDK users. To improve clarity, I recommend adding comments to the NetworkInfo class to explain the purpose of each group of fields (generic, lan_*, and wifi_*).

Additionally, for better readability and consistency, all wifi_* fields should be grouped together. The current placement separates wifi_ssid from the other wifi_ attributes. Consider reordering them to improve code organization.

As a minor improvement, consider ordering the new fields alphabetically.

Suggested change
wifi_mac: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None
wifi_mac: str | None = None

@jabdoa2

jabdoa2 commented Apr 3, 2026

Copy link
Copy Markdown

See #29 for samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some fields are unknown to prusactl printer show

2 participants