Skip to content

fix: Add model and CLI fields for missing Core One info. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dcode wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Add model and CLI fields for missing Core One info. #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/prusa/connect/client/models/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ class NetworkInfo(WarnExtraFieldsModel):
ipv4: str | None = None
ipv6: str | None = None
mac: str | None = None
wifi_mac: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None
Comment on lines +37 to +39

@gemini-code-assist gemini-code-assist Bot Mar 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding these specific wifi_* fields is useful, it introduces ambiguity with the existing generic ipv4, ipv6, and mac fields. It's now unclear what the top-level fields represent (e.g., LAN, WiFi, or the primary active interface), which can be confusing for SDK users. To improve clarity, I recommend adding comments to the NetworkInfo class to explain the purpose of each group of fields (generic, lan_*, and wifi_*).

Additionally, for better readability and consistency, all wifi_* fields should be grouped together. The current placement separates wifi_ssid from the other wifi_ attributes. Consider reordering them to improve code organization.

As a minor improvement, consider ordering the new fields alphabetically.

Suggested change
wifi_mac: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None
wifi_ipv4: str | None = None
wifi_ipv6: str | None = None
wifi_mac: str | None = None

wifi_ssid: str | None = None
lan_ipv4: str | None = None
lan_mac: str | None = None
Expand Down
Loading