Skip to content

Revert #1738: 恢复卡片页脚默认品牌文案为纯 botmux 链接 - #1769

Closed
47seek wants to merge 1 commit into
deepcoldy:masterfrom
47seek:47seek/revert-1738-footer-copy-20261009
Closed

47seek wants to merge 1 commit into
deepcoldy:masterfrom
47seek:47seek/revert-1738-footer-copy-20261009

Conversation

@47seek

@47seek 47seek commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Reverts #1738 (feat(lark): 更新飞书卡片默认页脚文案), merged 2026-10-09.

#1738 changed the default reply-card footer brand from a plain repo link:

[botmux](https://github.com/deepcoldy/botmux)

to:

Powered by botmux with ❤

This copy had never shipped on any previous release; fleet users immediately noticed the new watermark and asked to revert. This restores the original default exactly (6 files, 13 lines, the mechanical reverse diff). Per-bot custom brandLabel and the empty-string "suppress footer" behavior are unchanged — only the default text is rolled back.

Tests

test/md-card.test.ts passes (no test references the "Powered by ... with :LOVE:" string — the default is asserted structurally).

🤖 Generated with Claude Code

Restores the plain [botmux](https://github.com/deepcoldy/botmux) default
footer brand. The "Powered by ... with ❤" copy was not on any previous
release and was not wanted on the fleet cards.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@deepcoldy

Copy link
Copy Markdown
Owner

你好,自动评审初步意见如下(最终以维护者审阅为准):

结论:revert 本身干净,0 阻断,可以合入。 6 个文件 +13/-13 与 #1738 的原始改动逐字对应;逐字比对确认默认签名已恢复为纯 [botmux](https://github.com/deepcoldy/botmux) 链接,自定义 brandLabel 与空串隐藏行为不受影响。本地基于最新 master 验证:构建通过,相关卡片/配置测试全绿。

有三点同步一下:

  1. 一处事实更正:PR 描述里的 "had never shipped on any previous release" 不太准确——feat(lark): 更新飞书卡片默认页脚文案 #1738 已经包含在 v3.38.0(tag 72ed9a68c,当前 npm latest,Release notes 中也列出了「卡片默认页脚文案更新(feat(lark): 更新飞书卡片默认页脚文案 #1738)」),v3.37.0 则不含。所以这次回退实际上是修复已上线 latest 的回归,合并后建议尽快补一个 patch 版(如 3.38.1),方便 npm 用户拿到修复。

  2. 与 fix(input): 移除投递迟到提醒与状态栏 ID 拦截,新增卡片页脚签名总开关 #1770 去重:fix(input): 移除投递迟到提醒与状态栏 ID 拦截,新增卡片页脚签名总开关 #1770 里包含的页脚回退与本 PR 是同一份改动(6 个文件的 patch 逐字相同)。两个 PR 只需要合一个,否则重复合并会造成冲突和历史混乱。建议把本 PR(纯 revert,范围小且已评审通过)作为页脚回退先合;fix(input): 移除投递迟到提醒与状态栏 ID 拦截,新增卡片页脚签名总开关 #1770 rebase 后页脚部分会自然变为空 diff,继续保留它的另外两个独立改动即可。如果你有相反的倾向(比如想只保留 fix(input): 移除投递迟到提醒与状态栏 ID 拦截,新增卡片页脚签名总开关 #1770),也请告诉我们。

  3. 与 master 的冲突:本 PR 目前与最新 master 有小冲突,原因是 feat(lark): 更新飞书卡片默认页脚文案 #1738 合入后 master 又给 brandLabel 的说明文字加了「仅在最终回答与顶层广播卡片展示」的限定语。rebase 时保留该限定语、同时采用回退后的文案即可(en/zh 文档和 dashboard i18n 各一处,均为机械冲突),回退后对 master 仍恰好是 6 文件 +13/-13。

麻烦确认下第 2 点的意向;第 3 点你方便 rebase 最好,合入时由维护者解决也可以。谢谢!

@deepcoldy

Copy link
Copy Markdown
Owner

感谢提出!评估后我们没有采用「直接回退默认文案」的方式,而是在 #1770 中加入了一个机器级总开关来更彻底地解决这个诉求:

  • Dashboard「设置 → 飞书卡片」新增「在卡片页脚显示品牌签名」开关(缺省开启);
  • 关闭后,所有 Bot 的回复卡 / 顶层广播卡页脚都不再显示品牌签名(默认 botmux 链接与各 Bot 自定义签名一并关闭),同时每个 Bot 配置页的签名编辑框会置灰并提供跳转全局设置的链接;
  • 默认文案本身保持不变。

#1770 已合入 master,因此本纯回退 PR 不再需要,先关闭。再次感谢,也欢迎继续关注后续版本。

@deepcoldy deepcoldy closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants