fix: explicitly checkpoint WAL on shutdown to ensure consolidation#105
Merged
Conversation
pool.close() only triggers a passive checkpoint which can leave WAL files unconsolidated. Use PRAGMA wal_checkpoint(TRUNCATE) to force all WAL data back into the main database before closing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRAGMA wal_checkpoint(TRUNCATE)call before closing the SQLite connection pool during shutdownpool.close()alone only triggers a passive checkpoint, which can leave WAL/SHM files behind after the process exitstaskmillfrom 0.7.1 to 0.6.0 to match the API used in the codebaseWhy
SQLite WAL mode relies on checkpointing to consolidate write-ahead log data back into the main database file. The default passive checkpoint performed by
sqlx::Pool::close()is best-effort and may leave-waland-shmfiles on disk after shutdown. Over time (or after unclean exits), this can lead to stale WAL files or unexpected state on restart. ATRUNCATEcheckpoint forces full consolidation and removes the WAL file.Test plan
-wal/-shmfilescargo test)taskmill0.6.0 compiles and works correctly with the current task scheduling code