Skip to content

fix: explicitly checkpoint WAL on shutdown to ensure consolidation #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepjoy merged 2 commits into from
Mar 28, 2026
Merged

fix: explicitly checkpoint WAL on shutdown to ensure consolidation #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94fe5f
fix: explicitly checkpoint WAL on shutdown to ensure consolidation
deepjoy Mar 26, 2026
078d538
Merge branch 'main' into close-db-on-exit
deepjoy Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/metadata/sqlite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,14 @@ impl MetadataStore {

/// Gracefully close the metadata store, flushing WAL to the main database.
pub async fn close(&self) {
// Explicitly checkpoint and truncate the WAL before closing.
// pool.close() alone only passively checkpoints which may leave WAL files behind.
if let Err(e) = sqlx::query("PRAGMA wal_checkpoint(TRUNCATE)")
.execute(&self.pool)
.await
{
tracing::warn!("WAL checkpoint failed during shutdown: {e}");
}
self.pool.close().await;
}

Expand Down
Loading