fix(repair): 修复 OrderService.calculateDiscountPrice 的 BigDecimal 精度问题#22
Open
deibudei wants to merge 1 commit into
Open
fix(repair): 修复 OrderService.calculateDiscountPrice 的 BigDecimal 精度问题#22deibudei wants to merge 1 commit into
deibudei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto Repair
Session:
pr-precision-20260506-001608Plan
RepairPlan[repairTarget=修复 OrderService.calculateDiscountPrice 的 BigDecimal 精度问题, rootCauseHypothesis=calculateDiscountPrice 将 BigDecimal 转为 double 进行乘法运算,引入 IEEE 754 浮点精度误差。, suspectedFiles=[target-service/src/main/java/com/example/targetservice/service/OrderService.java, target-service/src/test/java/com/example/targetservice/service/OrderServicePrecisionTest.java], steps=[将 discountRate 从 double 转为 BigDecimal,使用 BigDecimal.valueOf(discountRate)。, 用 BigDecimal.multiply 链式计算 total.multiply(discountRateBD).multiply(quantityBD),全程保持 BigDecimal。, 移除 double 中间变量 perItem,直接返回 BigDecimal 结果。, 运行 target-service 测试验证精度修复。], testCommand=mvn -pl target-service test]
Review
Patch is limited to target-service and tests pass.