Skip to content

fix(repair): 修复 OrderService.calculateDiscountPrice 的 BigDecimal 精度问题 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deibudei wants to merge 1 commit into
base: demo/fault/precision-loss
Choose a base branch
from
Open

fix(repair): 修复 OrderService.calculateDiscountPrice 的 BigDecimal 精度问题 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions target-service/files/welcome.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
hello from storage
7 changes: 4 additions & 3 deletions target-service/src/main/java/com/example/targetservice/service/OrderService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public int calculateUnitPrice(int totalCents, int quantity) {

/**
* Calculates the discounted price for a bulk order.
* BUG: Uses double for intermediate calculation, causing floating-point precision loss.
* Uses BigDecimal throughout to avoid floating-point precision loss.
*/
public BigDecimal calculateDiscountPrice(BigDecimal total, double discountRate, int quantity) {
if (quantity <= 0) {
Expand All @@ -25,7 +25,8 @@ public BigDecimal calculateDiscountPrice(BigDecimal total, double discountRate,
if (discountRate <= 0 || discountRate >= 1) {
throw new IllegalArgumentException("discountRate must be between 0 and 1, but got: " + discountRate);
}
double perItem = total.doubleValue() * discountRate;
return BigDecimal.valueOf(perItem * quantity);
BigDecimal discountRateBD = BigDecimal.valueOf(discountRate);
BigDecimal quantityBD = BigDecimal.valueOf(quantity);
return total.multiply(discountRateBD).multiply(quantityBD);
}
}