Skip to content

fix #7: CI login-before-scan order, d-engine main, Docker badge - #8

Merged
JoshuaChi merged 1 commit into
mainfrom
fix/7-docker-release
Jul 29, 2026
Merged

JoshuaChi merged 1 commit into
mainfrom
fix/7-docker-release

Conversation

@JoshuaChi

@JoshuaChi JoshuaChi commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Improved Docker image release automation by authenticating earlier in the build process and allowing intentional shell syntax during manifest creation.
    • Updated the engine dependency to track the main development branch.
  • Documentation

    • Added a Docker Hub pull-count badge to the README.

docker-release.yml: Docker Scout needs an authenticated session even for
local images — login now runs before the CVE scan (was after, caused
exit 125 on both platforms).

d-lmdb: d-engine dependency back to main (fix/425-leader-hint merged).

README: add Docker Pulls badge.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 42249771-2ac9-40e7-bb14-f1a67ac74cbc

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6e501 and 55bdf83.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .github/workflows/docker-release.yml
  • README.md
  • d-lmdb/Cargo.toml

📝 Walkthrough

Walkthrough

The PR moves Docker Hub authentication before Docker Scout scanning, adds a ShellCheck suppression for manifest creation, adds a Docker Pulls badge, and updates both d-engine dependency declarations to use the main branch.

Changes

Release and dependency maintenance

Layer / File(s) Summary
Docker release workflow and badge updates
.github/workflows/docker-release.yml, README.md
Docker Hub login now runs before the Docker Scout scan, the later duplicate login is removed, intentional manifest digest word-splitting is suppressed for ShellCheck, and a Docker Pulls badge is added.
d-engine dependency branch update
d-lmdb/Cargo.toml
Both runtime and development d-engine dependencies now use the main branch while preserving their existing feature settings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Possibly related PRs

  • deventlab/d-lmdb#6 — Adds the Docker Scout CVE-check gate affected by the workflow login ordering.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the three main changes: CI login order, d-engine branch update, and the Docker badge addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/7-docker-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JoshuaChi
JoshuaChi merged commit 084a57d into main Jul 29, 2026
6 checks passed
@JoshuaChi
JoshuaChi deleted the fix/7-docker-release branch July 29, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant