Gate python cli-output tests on deptry as well as ruff#64
Merged
Conversation
devill
approved these changes
Jun 25, 2026
devill
left a comment
Owner
There was a problem hiding this comment.
Correct root-caused gating fix: a missing deptry hits recordSpawnFailure -> sink.failures -> exit 1, so the clean-run case must require both tools to assert exit 0. Brings cli-output.test.ts in line with python-acceptance.test.ts. Test-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gate the two Python cases in
src/cli-output.test.tson deptry as well as ruff.Why
The Python preset runs both ruff and deptry, but these cases were gated on ruff only (
skipIf(!RUFF)). With ruff present and deptry missing, the "python clean run" case fails: deptry's spawn failure forces exit 1, while the case expects exit 0 on a clean project.python-acceptance.test.tsalready gates on both tools for this reason; this bringscli-output.test.tsin line.Changes
src/cli-output.test.ts:RUFF→PY_TOOLS(ruff and deptry), and the twoit.skipIf(!RUFF)→it.skipIf(!PY_TOOLS).Test-only, no production code touched.
Testing
On a clean
main: