Skip to content

Gate python cli-output tests on deptry as well as ruff #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devill merged 1 commit into from
Jun 25, 2026
Merged

Gate python cli-output tests on deptry as well as ruff #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/cli-output.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ import { run } from './runner.js';

const here = dirname(fileURLToPath(import.meta.url));
const fixtures = join(here, '..', 'tests', 'fixtures');
const RUFF = spawnSync('ruff', ['--version']).status === 0;
// The Python preset shells out to ruff and deptry; skip these python e2e cases
// where the toolchain is incomplete so the suite stays green everywhere.
const PY_TOOLS =
spawnSync('ruff', ['--version']).status === 0 && spawnSync('deptry', ['--version']).status === 0;

const CLEAN_BANNER = '✅ Habit Hooks: automated checks passed.';

Expand All @@ -35,7 +38,7 @@ describe('CLI output — clean-run banner + violation-run output', () => {
expect(result.stdout).toContain('Violations:');
});

it.skipIf(!RUFF)('python clean run prints the pass banner (exit 0)', async () => {
it.skipIf(!PY_TOOLS)('python clean run prints the pass banner (exit 0)', async () => {
dir = mkdtempSync(join(tmpdir(), 'hh-pyclean-'));
writeFileSync(join(dir, 'habit-hooks.config.json'), JSON.stringify({ language: 'python' }));
writeFileSync(join(dir, 'ok.py'), 'def add(a, b):\n return a + b\n');
Expand All @@ -46,7 +49,7 @@ describe('CLI output — clean-run banner + violation-run output', () => {
expect(result.stdout.startsWith(CLEAN_BANNER)).toBe(true);
});

it.skipIf(!RUFF)('python violation run prints the count header and a coached section (exit 1)', async () => {
it.skipIf(!PY_TOOLS)('python violation run prints the count header and a coached section (exit 1)', async () => {
const result = await run(join(fixtures, 'python-project'));
expect(result.exitCode).toBe(1);
expect(result.stdout).toMatch(/^❌ Habit Hooks: \d+ violations/);
Expand Down