fix(site-kit): the footer link row carries the body-2 size - #50
Merged
Conversation
The kit gave `.site-footer__links` its layout and colour but no size, so the row inherited the 16px body and read a step larger than the same row on a sibling product's page. Every consumer that noticed had added the rule locally, with a comment saying the row rules would live per product "until site-kit's SiteFooter carries them" — 0.7.0 carried the rows but not this line, so deleting the local copy would have put the size back to 16px.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dds#47(가족 푸터)의 후속 한 줄입니다. 소비자 이관 중에 발견했습니다.
kit은
.site-footer__links에 레이아웃과 색만 주고 크기를 안 줍니다. 그래서 푸터가 16px 본문 크기를 물려받아 형제 제품의 같은 행보다 한 단계 크게 읽힙니다. VisionLinq는 로컬로 고쳐 두고 주석에 이렇게 적어 놨습니다:0.7.0이 행들은 가져왔지만 이 한 줄은 빠뜨렸습니다. 그대로면 VisionLinq가 자기 사본을 지우는 순간 16px로 회귀하고, kit 기본값을 쓰는 AskLinq는 지금도 16px입니다 — 이 작업이 없애려던 바로 그 불일치입니다.
.site-footer__links { font-size: var(--dds-typo-body-2-font-size); }를 kit에 넣고 테스트로 고정했습니다.검증:
verify:site-kit:ui·check(docs sync·consumer 벤더링) 통과,footer.test.tsx8/8.changeset은 patch입니다 — 0.8.0이 이미 나갔으니 0.8.1로 착지합니다.