Skip to content

fix(site-kit): the footer link row carries the body-2 size #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlc488 merged 1 commit into from
Sep 6, 2026
Merged

fix(site-kit): the footer link row carries the body-2 size #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/site-kit-footer-link-size.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@devslab/site-kit": patch
---

`.site-footer__links` gets the body-2 size. The kit gave the row layout and colour but no size, so the footer inherited the 16px body and read a step larger than the same row on a sibling product's page; every consumer that noticed had added the rule locally, which is the drift the footer release exists to end.

`.site-footer__links`에 body-2 크기 지정. kit이 이 행에 레이아웃과 색만 주고 크기를 안 줘서 푸터가 16px 본문 크기를 물려받아 형제 제품의 같은 행보다 한 단계 크게 읽혔습니다. 알아챈 소비자마다 로컬로 규칙을 넣어 뒀는데, 그 드리프트가 바로 이 푸터 릴리스가 끝내려는 것입니다.
7 changes: 7 additions & 0 deletions packages/site-kit/src/solid/__tests__/footer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,10 @@ it("ships the rules the three rows need, so no consumer has to keep its own copy
expect(STYLES).toContain(rule);
}
});

it("sizes the footer link row, so it does not inherit the body step", () => {
// Without this the row renders at the 16px body size and reads a step larger
// than the same row on a sibling product's page. Each consumer that noticed
// had added the rule locally.
expect(STYLES).toMatch(/\.site-footer__links \{ font-size: var\(--dds-typo-body-2-font-size\); \}/);
});
4 changes: 4 additions & 0 deletions packages/site-kit/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
.site-locale { inline-size: auto; min-inline-size: 9rem; }
.site-footer { border-block-start: 1px solid var(--dds-color-border-default); margin-block-start: var(--dds-space-64); padding-block: var(--dds-space-32); }
.site-footer__inner { inline-size: min(100% - var(--dds-space-32), 1120px); margin-inline: auto; display: grid; gap: var(--dds-space-16); }
/* The kit gave these rows layout and colour but no size, so the footer
inherited the 16px body and read a step larger than the same row on a
sibling product's page. Every consumer that noticed fixed it locally. */
.site-footer__links { font-size: var(--dds-typo-body-2-font-size); }
.site-footer__langs { display: flex; flex-wrap: wrap; gap: var(--dds-space-8) var(--dds-space-16); font-size: var(--dds-typo-caption-font-size); }
.site-footer__langs a { color: var(--dds-color-text-muted); text-decoration: none; }
.site-footer__langs a:hover { color: var(--dds-color-text-primary); }
Expand Down