Skip to content

feat: use yesterdays expectations if expectation is skipped today#556

Merged
tombrooks248 merged 1 commit into
mainfrom
feat/use-yesterdays-expectations-if-expectation-is-skipped-today
May 28, 2026
Merged

feat: use yesterdays expectations if expectation is skipped today#556
tombrooks248 merged 1 commit into
mainfrom
feat/use-yesterdays-expectations-if-expectation-is-skipped-today

Conversation

@tombrooks248
Copy link
Copy Markdown
Contributor

@tombrooks248 tombrooks248 commented May 27, 2026

Description

Update our expectations code so that it uses yesterdays expectations if expectation is skipped today

Why

Currently while the pipelines run faster when the duplicate_geometry_check is only run on saturday, the outcome of those tests are only available on saturdays when we want them to be available all week.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@tombrooks248 tombrooks248 force-pushed the feat/use-yesterdays-expectations-if-expectation-is-skipped-today branch from 3ea8c47 to 6ad3ab7 Compare May 27, 2026 11:31
@tombrooks248 tombrooks248 force-pushed the feat/use-yesterdays-expectations-if-expectation-is-skipped-today branch from 6ad3ab7 to 248164a Compare May 27, 2026 11:40
@tombrooks248 tombrooks248 force-pushed the feat/use-yesterdays-expectations-if-expectation-is-skipped-today branch from 248164a to 68bf380 Compare May 27, 2026 11:47
@tombrooks248 tombrooks248 marked this pull request as ready for review May 27, 2026 11:55
Copy link
Copy Markdown
Contributor

@gibahjoe gibahjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombrooks248 tombrooks248 merged commit 02314e5 into main May 28, 2026
5 checks passed
@tombrooks248 tombrooks248 deleted the feat/use-yesterdays-expectations-if-expectation-is-skipped-today branch May 28, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants