App Spotify tp digitalers#10
Open
agustinajimenez2020 wants to merge 12 commits intodigitalers2021:mainfrom
Open
App Spotify tp digitalers#10agustinajimenez2020 wants to merge 12 commits intodigitalers2021:mainfrom
agustinajimenez2020 wants to merge 12 commits intodigitalers2021:mainfrom
Conversation
nuxion
reviewed
Jun 22, 2021
Contributor
nuxion
left a comment
nuxion
left a comment
There was a problem hiding this comment.
Muy buen tp. Queda bien claro la evolucion del trabajo a partir de los comentarios de cada commit.
Bien detallada la explicacion de cada item. Es una opinion personal pero en el apartado tecnico tal vez me habria detenido mas en la parte de la tecnologia p2p que lo mencionan en el punto anterior.
Por ultimo un solo detalle, idealmente el pull request es recomendable que tenga un texto que englobe todos los cambios por ejemplo:
Informe sobre spotify, tp1.
Sigan asi muy buen trabajo 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.