set ens members to one, this is about 3x faster for a single forecast#12
Open
JoachimKoenigslieb wants to merge 5 commits intodmidk:mainfrom
Open
set ens members to one, this is about 3x faster for a single forecast#12JoachimKoenigslieb wants to merge 5 commits intodmidk:mainfrom
JoachimKoenigslieb wants to merge 5 commits intodmidk:mainfrom
Conversation
Contributor
|
Thanks @JoachimKoenigslieb ! This is great! But perhaps, we should do it a bit more future proof and use this variable from |
Author
|
Yes, that sounds like a great idea. I've used the value from the config instead! |
Contributor
|
Thanks a lot @JoachimKoenigslieb ! I can confirm the speed up: With update: Without update : If you fix the linting (with |
Contributor
KristianHMoller
left a comment
There was a problem hiding this comment.
With an entry in CHANGELOG.md, this is ready for approval and merge!
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [Unreleased] | ||
| - Pass down number of ensembles from configurations to `ProbabilisticAdvection`. This gives a roughly 3x speedup in the no ensembles case. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Pass down number of ensembles from configurations to `ProbabilisticAdvection`. This gives a roughly 3x speedup in the no ensembles case. | |
| - Pass down number of ensembles from configurations to `ProbabilisticAdvection`. This gives a roughly 3x speedup in the no ensembles case [!12](https://github.com/dmidk/sunflow/pull/12), @JoachimKoenigslieb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running with this change I get:
And without I get:
So wall-clock is about 3x faster and the user a lot lower because it does not do multi-processing stuff to get the ens members I presume.