Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
Comment thread
KristianHMoller marked this conversation as resolved.

### Changed

- Pass down number of ensembles from configurations to `ProbabilisticAdvection`. This gives a roughly 3x speedup in the no ensembles case [!12](https://github.com/dmidk/sunflow/pull/12), @JoachimKoenigslieb

## [v1.1.0]

### Added
Expand Down
5 changes: 2 additions & 3 deletions sunflow/forecast.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ def preprocess_data(


def simple_advection_forecast(
ratio_data: np.ndarray,
motion_field: np.ndarray,
n_steps: int,
ratio_data: np.ndarray, motion_field: np.ndarray, n_steps: int, ens_members: int
) -> np.ndarray:
"""Run a deterministic advection forecast on solar irradiance ratios.

Expand All @@ -90,6 +88,7 @@ def simple_advection_forecast(
alpha=0.0, # No Gaussian noise on motion field norm
beta=0.0, # No von Mises noise on motion field angle
return_motion_field=False,
ens_members=ens_members,
)
# Run probabilistic advection using the correct method name
forecast = pa.maps_forecast(n_steps, ratio_data, motion_field)
Expand Down
5 changes: 4 additions & 1 deletion sunflow/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,10 @@ def run_nowcast(

# Simple forecast (ratio forecast)
ratio_forecast = simple_advection_forecast(
ratio_data, motion_field, nowcast_config.future_steps
ratio_data,
motion_field,
nowcast_config.future_steps,
ens_members=nowcast_config.ens_members,
)

# Generate previous day time steps for clearsky lookup
Expand Down
Loading