feat: add ContentLayer.SHEET and serialize Excel sheet groups in HTML and Markdown#660
feat: add ContentLayer.SHEET and serialize Excel sheet groups in HTML and Markdown#660samiuc wants to merge 2 commits into
ContentLayer.SHEET and serialize Excel sheet groups in HTML and Markdown#660Conversation
…izers Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
|
✅ DCO Check Passed Thanks @samiuc, all your commits are properly signed off. 🎉 |
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
ContentLayer.SHEET and serialize Excel sheet groups in HTML and Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
|
@samiuc I don't think we should create a new content layer for the structural component derived from a workbook sheet for the same reason that we don't have a content layer for PDF pages or EPUB chapters. |
When converting a multi-sheet Excel file, there was no way to tell which table or piece of content belonged to which worksheet in the HTML or Markdown output. This PR fixes that by tagging visible worksheet groups with a dedicated content layer, so the HTML serializer can wrap each sheet's content in a labeled
<section>element and the Markdown serializer can emit a heading for each sheet.