fix: refine pre-push range#15
Merged
Merged
Conversation
Open
bniladridas
commented
May 21, 2026
| commits=$(git rev-list "$local_sha" --not --all) | ||
| else | ||
| commits=$(git rev-list "$local_sha" --not "$remote_sha") | ||
| default_remote_ref=$(git symbolic-ref -q --short "refs/remotes/$remote_name/HEAD" || true) |
Contributor
Author
There was a problem hiding this comment.
Cargo was needed for this dotfiles repo because its own lint and pre-push checks run cargo fmt and cargo clippy. The browser repo did not need Cargo for the Android PR; that earlier failure exposed this shared hook range issue, and this source repo is the right place to fix it so future installed hooks do not validate commits already on the remote default branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification