Skip to content

fix: refine pre-push range #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bniladridas merged 1 commit into from
May 21, 2026
Merged

fix: refine pre-push range #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion git-hooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ while read -r local_ref local_sha _ remote_sha; do
if [ "$remote_sha" = "0000000000000000000000000000000000000000" ]; then
commits=$(git rev-list "$local_sha" --not --all)
else
commits=$(git rev-list "$local_sha" --not "$remote_sha")
default_remote_ref=$(git symbolic-ref -q --short "refs/remotes/$remote_name/HEAD" || true)

@bniladridas bniladridas May 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo was needed for this dotfiles repo because its own lint and pre-push checks run cargo fmt and cargo clippy. The browser repo did not need Cargo for the Android PR; that earlier failure exposed this shared hook range issue, and this source repo is the right place to fix it so future installed hooks do not validate commits already on the remote default branch.

if [ -n "$default_remote_ref" ]; then
commits=$(git rev-list "$local_sha" --not "$remote_sha" "$default_remote_ref")
else
commits=$(git rev-list "$local_sha" --not "$remote_sha")
fi
fi

echo "🔎 Checking commits for $local_ref..."
Expand Down
Loading