Fix crash when deleting a heading question#2665
Merged
richardebeling merged 2 commits intoe-valuation:mainfrom Mar 10, 2026
Merged
Fix crash when deleting a heading question#2665richardebeling merged 2 commits intoe-valuation:mainfrom
richardebeling merged 2 commits intoe-valuation:mainfrom
Conversation
This got introduced in e-valuation#2513. The tests didn't explicitly cover deleting a heading question, but test_delete_question would still occasionally do it depending on the status of the RNG when running with --shuffle, because it didn't specify the question type so model baker would choose one at random.
Kakadus
approved these changes
Mar 9, 2026
Collaborator
Kakadus
left a comment
Kakadus
left a comment
There was a problem hiding this comment.
Thanks, I overlooked that answer_class only works correctly, if the question is not a heading.
richardebeling
approved these changes
Mar 9, 2026
niklasmohrin
approved these changes
Mar 9, 2026
Member
Kakadus
approved these changes
Mar 10, 2026
Collaborator
Kakadus
left a comment
Kakadus
left a comment
There was a problem hiding this comment.
good2go for me like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got introduced in #2513.
answer_classthrows on heading questions.The tests didn't explicitly cover deleting a heading question, but test_delete_question would still occasionally do it depending on the status of the RNG when running with --shuffle, because it didn't specify the question type so model baker would choose one at random. I saw this failing in a PR check for #2643.