Skip to content

Fix crash when deleting a heading question #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardebeling merged 2 commits into from
Mar 10, 2026
Merged

Fix crash when deleting a heading question #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0753f7
Fix crash when deleting a heading question
karyon Mar 8, 2026
974e291
Add comment
karyon Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions evap/evaluation/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,9 +1374,10 @@ class Meta:
unique_together = [("question", "questionnaire")]

def delete(self, using=None, keep_parents=False) -> tuple[int, dict[str, int]]:
assert not self.question.answer_class.objects.filter(assignment=self).exists(), (
"cannot delete question with answers"
)
if not self.question.is_heading_question:
assert not self.question.answer_class.objects.filter(assignment=self).exists(), (
"cannot delete question with answers"
)
Comment thread
Kakadus marked this conversation as resolved.
count = 0
meta: dict[str, int] = {}

Expand Down
5 changes: 4 additions & 1 deletion evap/staff/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3374,7 +3374,10 @@ def test_invalid_question_edit(self) -> None:

def test_delete_question(self) -> None:
other_questionnaire = baker.make(Questionnaire)
other_question = baker.make(Question, questionnaires=[self.questionnaire, other_questionnaire])
# Use HEADING to test for a regression, see https://github.com/e-valuation/EvaP/pull/2665
other_question = baker.make(
Question, questionnaires=[self.questionnaire, other_questionnaire], type=QuestionType.HEADING
)
baker.make(QuestionAssignment, questionnaire=self.questionnaire, question__type=QuestionType.GRADE)
baker.make(Contribution, questionnaires=[self.questionnaire], evaluation__state=Evaluation.State.NEW)
page = self.app.get(self.url, user=self.manager)
Expand Down