Skip to content

chore: Bump to 7.108.0-next in main - #23508

Merged
mkuznyetsov merged 2 commits into
mainfrom
pr-main-to-7.108.0-next
Aug 6, 2025
Merged

chore: Bump to 7.108.0-next in main#23508
mkuznyetsov merged 2 commits into
mainfrom
pr-main-to-7.108.0-next

Conversation

@che-bot

@che-bot che-bot commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Signed-off-by: Mykhailo Kuznietsov mkuznets@redhat.com

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

@mkuznyetsov mkuznyetsov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR contains undesired changes by prettier in .md files?

@dmytro-ndp dmytro-ndp mentioned this pull request Aug 4, 2025
9 tasks
@dmytro-ndp

dmytro-ndp commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

@mkuznyetsov:

PR contains undesired changes by Prettier in .md files?

Yes, they are not desired.
The root cause of changes is the different node version 16 in release.yml compared to version 18 in pr-check.yml.
What do you think about setting node version to 18 in release.yml as well to have the same npm run prettier command execution result?
Note: it's not possible to exclude .md files from prettier scan because of known bug.

At the same time, the formatting fix for the OauthPage.ts file is correct.

By the way, I have prepared a PR #23511 that should add a Prettier check to the PR checks.

@mkuznyetsov
mkuznyetsov merged commit 7b28434 into main Aug 6, 2025
6 checks passed
@mkuznyetsov
mkuznyetsov deleted the pr-main-to-7.108.0-next branch August 6, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants