Skip to content

Add prettirer PR check - #23511

Merged
dmytro-ndp merged 10 commits into
mainfrom
add-prettier-check
Aug 5, 2025
Merged

Add prettirer PR check#23511
dmytro-ndp merged 10 commits into
mainfrom
add-prettier-check

Conversation

@dmytro-ndp

@dmytro-ndp dmytro-ndp commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds a check for prettier formatting violations to the smoke test GitHub Action workflow. This will ensure code quality and consistent formatting across the codebase.

Change list:

  1. Added a prettier:check script to the e2e tests package.json
  2. Added a "Check prettier rules" step to the PR check workflow

Benefit: catches formatting inconsistencies early in the development process.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#23508

How to test this PR?

  • Verify that the CI pipeline runs the prettier check successfully
  • Test with intentionally malformatted code to ensure it fails correctly
  • Confirm that running npm run prettier fixes the issues

Example of prettier check failure:
https://github.com/eclipse-che/che/actions/runs/16735722106/job/47374004942

Warning: Prettier formatting issues found in the following files:
Warning: [warn] pageobjects/git-providers/OauthPage.ts
Run 'cd tests/e2e && npm run prettier' to fix formatting issues.
Error: Prettier check failed! Please fix the formatting issues.
Error: Process completed with exit code 1.

Example of successful run of prettier check:
https://github.com/eclipse-che/che/actions/runs/16735886970

Running prettier check...
No prettier formatting issues found.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

--
Assisted by Cursor

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp
dmytro-ndp requested a review from mkuznyetsov August 5, 2025 10:20
@dmytro-ndp
dmytro-ndp merged commit eb82bd5 into main Aug 5, 2025
6 checks passed
@dmytro-ndp
dmytro-ndp deleted the add-prettier-check branch August 5, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants