Conversation
DASH license validation and result comments do not require the API token. The token was used only by dash-licenses' -review option to open Eclipse IP Team review requests automatically.\n\nAutomatic review creation is intentionally removed from every CI run: it is an asynchronous escalation that may take time and needs a maintainer decision. The PR comment now links to DASH's manual review-request instructions for cases that need follow-up. Signed-off-by: Uwe Maucher <205777204+umaucher@users.noreply.github.com>
umaucher
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
September 15, 2026 15:45
Member
|
cant we fix the token? automatic review trigger was actually intentional. As we should actually wait for approval before merging. |
Contributor
Author
maybe the better approach have the secret optional so we can clarify why the org secret is not working but still have the check reporting the correct commend if needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the DASH API-token requirement from the reusable license-check workflow.
DASH license validation and the existing PR result comment work without a token. The token was used only by
dash-licenses -reviewto create Eclipse IP Team review requests automatically.Those requests are an asynchronous escalation and should be started deliberately when a maintainer decides follow-up is needed. The result comment now links to the DASH manual review-request instructions.
Validation:
bazel run --lockfile_mode=error //:license-check -- -project automotive.score -repo https://github.com/eclipse-score/persistency(passes; DASH reported review findings without a token)git diff --checkFollow-up: consumers can remove their
dash-api-tokensecret mapping when updating to this workflow revision.