Skip to content

Remove DASH review token #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umaucher wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −11
Open

Remove DASH review token #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/license-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ on:
token:
description: Token for private dependencies; an alternative to GitHub App credentials
required: false
dash-api-token:
description: "Eclipse DASH API Token for license verification"
required: true

jobs:
license-check:
Expand Down Expand Up @@ -92,10 +89,7 @@ jobs:
OUTPUT=""
EXIT_CODE=0

# Use org secret as fallback if dash-api-token is not provided
TOKEN="${{ secrets.dash-api-token }}"

CMD="bazel ${{ inputs.bazel-target }} -- -review -project automotive.score -repo $REPO_URL -token $TOKEN"
CMD="bazel ${{ inputs.bazel-target }} -- -project automotive.score -repo $REPO_URL"
echo "Running: $CMD"

CHECK_OUTPUT=$($CMD 2>&1)
Expand Down Expand Up @@ -136,6 +130,10 @@ jobs:

**Status:** ${{ env.exit_code == 0 && '✅ Passed' || '⚠️ Needs Review' }}

#### Manual IP review

This workflow reports license findings but does not create Eclipse IP Team review requests automatically. If a review is needed, follow the [DASH manual review-request instructions](https://github.com/eclipse-dash/dash-licenses#automatic-ip-team-review-requests).

<details>
<summary>Click to expand output</summary>

Expand Down
5 changes: 1 addition & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,11 @@ jobs:
with:
repo-url: "${{ github.server_url }}/${{ github.repository }}" # optional, this is the default
bazel-target: "run //:license-check" # optional, this is the default
secrets:
dash-api-token: ${{ secrets.ECLIPSE_GITLAB_API_TOKEN }} # mandatory - the Eclispe DASH API token
```

This workflow:

✅ Runs **DASH license compliance checks** for **Rust, C++, and Python**
✅ Uses the **organization secret** `ECLIPSE_GITLAB_API_TOKEN`
✅ Runs **license compliance checks** for **Rust, C++, and Python** without a DASH API token
✅ Comments results directly on the **Pull Request**

> ℹ️ **Note:** You can override the Bazel command using the `bazel-target` input.
Expand Down
Loading