Repository navigation
Preserve author-added empty lines between reflowed arguments in blink - #160
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #159, which made
StandaloneLinePromotedPropertyFixer(PHP) keep author-added empty lines between constructor arguments. The blink (Go) port still collapsed them, so blink diverged from ECS.Root cause
reflowParen()took acollapseBlanksflag. Constructor/call rules passedtrue, which collapsed a blank line between reflowed arguments down to a single newline (kept only before a plain comment). That mirrored the old PHP behavior. After #159 every PHP fixer routed throughTokensNewliner::breakItems()preserves blank lines, so the flag no longer had a PHP counterpart.Change
Dropped
collapseBlanksand madeargNLAfterComma()always keep an author-added blank line (2+ line endings), matching the PHP side. This covers everyreflowParen()caller: promoted / plain / required constructor params, call-argument spacing, and arrays (arrays already preserved).Updated the two tests that asserted the old collapse behavior to assert preservation instead - consistent with the existing note in
method_argument_space_phpcsfixer_test.gothat mautic parity needs blank lines kept. Added a promoted-property case covering a blank line before an#[Attribute].