Draft
Avoid matching subsumed rows in custom backoff scheduler path#54
Conversation
Agent-Logs-Url: https://github.com/egraphs-good/egglog-experimental/sessions/e64e91b0-d449-43f4-b233-dfe30f14a931 Co-authored-by: yihozhang <13150100+yihozhang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix custom scheduler subsumed rows issue
Avoid matching subsumed rows in custom backoff scheduler path
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom scheduler execution could still retain/apply matches for tuples that had become subsumed. This made scheduler behavior inconsistent with normal rule execution and could produce stale scheduled work.
Scheduler semantics alignment
egglogdependencies to the scheduler stale-match cleanup branch (codex/split-scheduler-stale-match-cleanup) so scheduled matches are revalidated/cleaned when rows are subsumed.run-withscheduler execution no longer treats subsumed tuples as valid pending matches.Saturate loop stop condition update
saturatestop logic to use report update semantics (!iter_report.updated) instead ofcan_stop, matching the updated scheduler report contract.Regression coverage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/saulshanabrook/egg-smol/commits/codex/split-scheduler-stale-match-cleanup/home/REDACTED/.rustup/toolchains/1.91.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.91.0-x86_64-REDACTED-linux-gnu/bin/cargo test --release --test integration_test test_backoff_scheduler_does_not_match_subsumed_rows -- --nocapture u.05.rcgu.o u.06.rcgu.o u.07.rcgu.o u.08.rcgu.o u.09�� u.10.rcgu.o /release/deps/egglog_experimental-2ba21daf64d3a11f.egglog_experimental.c6e477ede2665344-cgu.0.rc--no-pager /release/deps/files-062593e05073508a u.13.rcgu.o u.14.rcgu.o lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libtest-d28f7e25f6ac9e1b.rlib /release/deps/files-062593e05073508a(http block)https://api.github.com/repos/saulshanabrook/egg-smol/git/trees/c01695618ed4de2fbfa8116476e208bc1ca86612/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)If you need me to access, download, or install something from one of these locations, you can either: