Fix DETECTOR_CONFIG mismatch in secondary_vertexing_dis causing redundant simulations

[Copilot]

bench:secondary_vertexing_dis was requesting Snakemake targets under epic_craterlake while sim:tracking_performances_dis produces outputs for epic_craterlake_tracking_only. The config mismatch caused Snakemake to re-run trk_dis_sim and trk_dis_reco instead of reusing existing artifacts.

Changes

• benchmarks/secondary_vertexing_dis/config.yml: Replace epic_craterlake with epic_craterlake_tracking_only in the Snakemake target paths for both the bench and collect_results job scripts.

# before
- snakemake ... results/epic_craterlake/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

# after
- snakemake ... results/epic_craterlake_tracking_only/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

The Snakefile's {DETECTOR_CONFIG} wildcard resolves correctly from the output path — no Snakefile changes needed.

Original prompt

Problem

The bench:secondary_vertexing_dis CI job is running redundant simulations instead of reusing the outputs from sim:tracking_performances_dis.

The root cause is a DETECTOR_CONFIG mismatch in benchmarks/secondary_vertexing_dis/config.yml:

• sim:tracking_performances_dis produces reconstructed files for epic_craterlake_tracking_only
• bench:secondary_vertexing_dis requests results for epic_craterlake

Because the detector config doesn't match, Snakemake cannot satisfy the secondary vertexing input from the existing simulation outputs and re-runs trk_dis_sim and trk_dis_reco with DETECTOR_CONFIG=epic_craterlake, wasting CI time.

Evidence: https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7384366

Fix

In benchmarks/secondary_vertexing_dis/config.yml, change epic_craterlake to epic_craterlake_tracking_only in the snakemake target paths on two lines:

Line 8 (bench job script):

- snakemake $SNAKEMAKE_FLAGS --cores $MAX_CORES_PER_JOB results/epic_craterlake/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

should become:

- snakemake $SNAKEMAKE_FLAGS --cores $MAX_CORES_PER_JOB results/epic_craterlake_tracking_only/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

Line 18 (collect_results job script):

- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output results/epic_craterlake/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

should become:

- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output results/epic_craterlake_tracking_only/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

No changes are needed to the Snakefile itself — its {DETECTOR_CONFIG} wildcard will correctly resolve to epic_craterlake_tracking_only from the output path, and the input will then match the files already produced by sim:tracking_performances_dis.

This pull request was created from Copilot chat.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR fixes a Snakemake target-path detector configuration mismatch so bench:secondary_vertexing_dis reuses artifacts produced by sim:tracking_performances_dis instead of redundantly re-running simulation/reconstruction.

Changes:

• Update bench:secondary_vertexing_dis Snakemake target to use results/epic_craterlake_tracking_only/....
• Update collect_results:secondary_vertexing_dis Snakemake deletion target to use the same epic_craterlake_tracking_only path.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.