Skip to content

Fix DETECTOR_CONFIG mismatch in secondary_vertexing_dis causing redundant simulations #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wdconinc merged 2 commits into from
Mar 7, 2026
+2 −2
Merged

Fix DETECTOR_CONFIG mismatch in secondary_vertexing_dis causing redundant simulations #264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
262645d
Initial plan
Copilot Mar 6, 2026
6a5d076
fix: use epic_craterlake_tracking_only in secondary_vertexing_dis config
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benchmarks/secondary_vertexing_dis/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ bench:secondary_vertexing_dis:
# Re-use simulations from the tracking benchmark
- ["sim:tracking_performances_dis"]
script:
- snakemake $SNAKEMAKE_FLAGS --cores $MAX_CORES_PER_JOB results/epic_craterlake/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png
- snakemake $SNAKEMAKE_FLAGS --cores $MAX_CORES_PER_JOB results/epic_craterlake_tracking_only/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png

collect_results:secondary_vertexing_dis:
extends: .det_benchmark
Expand All @@ -15,5 +15,5 @@ collect_results:secondary_vertexing_dis:
script:
- ls -lrht
- mv results{,_save}/ # move results directory out of the way to preserve it
- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output results/epic_craterlake/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png
- snakemake $SNAKEMAKE_FLAGS --cores 1 --delete-all-output results/epic_craterlake_tracking_only/secondary_vertex_pythia8NCDIS_18x275_minQ2=1_SecondaryVerticesHelix.png
- mv results{_save,}/