Move support to OTP 22+#114
Conversation
There was a problem hiding this comment.
Work in blacklist mode (accept all defaults except...), and add test to the mix.
| case catch elli_tcp:accept(ListenSocket, Server, accept_timeout(Options)) of | ||
| case elli_tcp:accept(ListenSocket, Server, accept_timeout(Options)) of |
There was a problem hiding this comment.
I don't see where catch was actually used, since all the clauses derive not from exceptions, but simple function returns.
662c4e5 to
529a1a0
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 76.32% 76.40% +0.07%
==========================================
Files 12 12
Lines 756 750 -6
==========================================
- Hits 577 573 -4
+ Misses 179 177 -2
☔ View full report in Codecov by Sentry. |
529a1a0 to
217b4f5
Compare
|
|
|
|
|
|
a137e37 to
829beda
Compare
|
Woo, these are all looking good. And yea, for 26 the ssl certs may need to be re-created. I had to do this for chatterbox tests too. |
|
Is anything lacking for this one to get merged? I can then rebase and update the other ones. I think I'll deal with OTP 26 in a separate PR so as to not inflict further confusion in these pull requests... 😄 |
In CI we also update some of the action tools' versions
... and add warnings_as_errors
829beda to
66f17c6
Compare
|
@tsloughter, if you prefer I can also reduce the scope for this and do multiple pull requests to an isolated branch until you're fully satisfied and then we merge to the main branch. |
|
This doesn't look too bad, I just hadn't taken a close look. |
|
@tsloughter, what's required to push this forward? |
|
Hey sorry, it is just a large PR. But it looks like a lot of it is formatting? |
|
👋 it's probably the commit related to Elvis, but I can try to break it down further. |
|
I'm moving to draft, to be able to break it down into several pull requests. Once that's done, I'll close this one without it being merged. |
|
All new pull requests mentioned in the top description. |
Closes #103.
This pull request is being split into several other pull requests, to ease review. These are listed below.
rebar.config(update deps then fixed issue warnings) #120