Update code for the new OTP 22-25 maintenance range#119
Merged
tsloughter merged 4 commits intoelli-lib:mainfrom Jun 13, 2024
Merged
Update code for the new OTP 22-25 maintenance range#119tsloughter merged 4 commits intoelli-lib:mainfrom
tsloughter merged 4 commits intoelli-lib:mainfrom
Conversation
In CI we also update some of the action tools' versions
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 76.32% 76.40% +0.07%
==========================================
Files 12 12
Lines 756 750 -6
==========================================
- Hits 577 573 -4
+ Misses 179 177 -2 ☔ View full report in Codecov by Sentry. |
paulo-ferraz-oliveira
changed the title
We: - (temporarily) remove rebar3_lint to re-enable it later - stop failing fast (this can be considered as an enhancement)
paulo-ferraz-oliveira
force-pushed
the
feature/otp-22+_22-to-27
branch
from
6d76440 to
3c81e4c
Compare
Closed
Contributor
Author
Member
|
Thanks for these! I will get to this very soon. |
tsloughter
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly removing code and updating the CI pipeline for 22-25 (now with cache).
(I took the liberty to update the minimum to OTP 22 - this was previously, in the "other" pull request OTP 21, but in the meantime an extra OTP version was released)
In CI we also update some of the action tools' versions.
Further considerations
The pull request is probably best seen with
Hide whitespaceenabled, since there's some changes that are just indentation ones.I'm also temporarily disabling
rebar3_lintin this pull request, since that bring other issues with it requiring to be updated, but will handle it in a subsequent pull request.Note: support for OTP 26 and 27 is not present, as this was discussed before: #114 (comment)