Skip to content

i18n(fr): add missing translations for plugins registry & social image#1041

Merged
ascorbic merged 2 commits into
emdash-cms:mainfrom
ArmandPhilippot:i18n/fr
May 14, 2026
Merged

i18n(fr): add missing translations for plugins registry & social image#1041
ascorbic merged 2 commits into
emdash-cms:mainfrom
ArmandPhilippot:i18n/fr

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds missing French translations for the plugins registry and social images.

Note that I wasn't able to check the translations for the plugins registry in the UI:

  • Following the instructions in From the Marketplace on the simple demo gives me an error (Cannot find module 'true' imported from 'virtual:emdash/sandbox-runner').
  • I wanted to try the Cloudflare demo since the marketplace is already configured but... I'm not sure what is going wrong: I got an infinite redirection loop on the login page. 😅

But, I don't see any UI strings that could have another meaning/translation according to the UI so it should be safe.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool:

Screenshots / test output

N/A

Copilot AI review requested due to automatic review settings May 14, 2026 11:21
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: d4cb4cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/fr/messages.po Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@1041

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@1041

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@1041

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@1041

emdash

npm i https://pkg.pr.new/emdash@1041

create-emdash

npm i https://pkg.pr.new/create-emdash@1041

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@1041

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@1041

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@1041

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@1041

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@1041

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@1041

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@1041

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@1041

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@1041

commit: d4cb4cc

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing French (fr) translations for Admin UI strings related to the plugin registry and default social image settings, improving localization completeness in the admin experience.

Changes:

  • Added French translations for plugin registry browse/detail UI strings.
  • Added French translations for social image / referenced image messaging in SEO settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 4996 to +4998
#: packages/admin/src/components/settings/GeneralSettings.tsx:251
msgid "Referenced favicon unavailable."
msgstr ""
msgstr "Favicon référencée indisponible."
Copy link
Copy Markdown
Contributor Author

@ArmandPhilippot ArmandPhilippot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is the other way around. "Modifier le favicon" is wrong, favicon is feminine (e.g. https://fr.wikipedia.org/wiki/Favicon). Fixed in d4cb4cc
Edit: well, both are acceptable (https://fr.wiktionary.org/wiki/favicon), but yes we should be consistent.

Copy link
Copy Markdown
Collaborator

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah the marketplace stuff is under heavy development at the moment, so isn't working properly on main.

@ascorbic ascorbic merged commit 2d1eeab into emdash-cms:main May 14, 2026
37 checks passed
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr branch May 14, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants