🎨 Palette: Add ARIA labels to icon-only toggle buttons - #231
Conversation
Co-authored-by: endlessblink <37155282+endlessblink@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
aria-label,aria-pressed, andaria-expandedattributes to icon-only toggle buttons acrossViewControls.vue,AccountSettingsTab.vue, andAISettingsTab.vue.🎯 Why: Without these attributes, screen readers only announce "button" and lack context on what the button does or its current state (e.g. is the password currently visible or hidden?). Adding clear labels and state bindings provides proper context for keyboard and assistive tech users.
📸 Before/After: Visual presentation is identical (no CSS changes), but structural HTML is now accessible. Tooltip
titleproperties were also refined to dynamically reflect current interaction state.♿ Accessibility: Ensures WCAG compliance by explicitly naming buttons that rely purely on visual iconography and announcing dynamic toggle state changes.
PR created automatically by Jules for task 7071769824628184216 started by @endlessblink