Skip to content

🎨 Palette: Add ARIA labels to icon-only toggle buttons #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
endlessblink wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Add ARIA labels to icon-only toggle buttons #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/layout/ViewControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
class="filter-toggle"
:class="{ active: showFilters }"
title="Toggle filters"
aria-label="Toggle filters"
:aria-expanded="showFilters"
@click="showFilters = !showFilters"
>
<SlidersHorizontal :size="20" :stroke-width="1.5" />
Expand All @@ -17,6 +19,8 @@
class="done-toggle"
:class="{ active: hideDoneTasks }"
:title="hideDoneTasks ? 'Show completed tasks' : 'Hide completed tasks'"
:aria-label="hideDoneTasks ? 'Show completed tasks' : 'Hide completed tasks'"
:aria-pressed="hideDoneTasks"
@click="$emit('update:hideDoneTasks', !hideDoneTasks)"
>
<EyeOff v-if="hideDoneTasks" :size="20" :stroke-width="1.5" />
Expand Down
8 changes: 7 additions & 1 deletion src/components/settings/tabs/AISettingsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,13 @@ async function onClearMemories() {
spellcheck="false"
autocomplete="off"
/>
<button class="key-toggle-btn" @click="showGroqKey = !showGroqKey" :title="showGroqKey ? 'Hide' : 'Show'">
<button
class="key-toggle-btn"
:title="showGroqKey ? 'Hide API key' : 'Show API key'"
:aria-label="showGroqKey ? 'Hide API key' : 'Show API key'"
:aria-pressed="showGroqKey"
@click="showGroqKey = !showGroqKey"
>
<EyeOff v-if="showGroqKey" :size="14" />
<Eye v-else :size="14" />
</button>
Expand Down
15 changes: 13 additions & 2 deletions src/components/settings/tabs/AccountSettingsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,13 @@ const handleChangePassword = async () => {
class="form-input"
placeholder="Enter new password"
>
<button class="toggle-visibility" @click="showPassword = !showPassword">
<button
class="toggle-visibility"
:title="showPassword ? 'Hide password' : 'Show password'"
:aria-label="showPassword ? 'Hide password' : 'Show password'"
:aria-pressed="showPassword"
@click="showPassword = !showPassword"
>
<Eye v-if="!showPassword" :size="16" />
<EyeOff v-else :size="16" />
</button>
Expand Down Expand Up @@ -504,7 +510,12 @@ const handleChangePassword = async () => {
class="form-input"
@focus="(e) => (e.target as HTMLInputElement).select()"
>
<button class="toggle-visibility" :title="localApiCopied ? 'Copied!' : 'Copy'" @click="copyLocalApiToken">
<button
class="toggle-visibility"
:title="localApiCopied ? 'Copied!' : 'Copy'"
:aria-label="localApiCopied ? 'Copied!' : 'Copy'"
@click="copyLocalApiToken"
>
<Check v-if="localApiCopied" :size="16" />
<Copy v-else :size="16" />
</button>
Expand Down
Loading