fix(webhook): fail GraphQL responses with errors#78
Open
volcano303 wants to merge 1 commit into
Open
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fail GraphQL metadata and backfill fetches when GitHub returns response-level
errors, even if the HTTP status is successful.This reuses a shared GraphQL error guard across the existing content fetch path and adds the same protection to PR metadata, PR backfill, and issue backfill. Backfill now also fails when an expected root page is missing instead of silently ending the loop.
Related Issues
Fixes #77
Type of Change
Testing
npm run format:checknpm run lintnpm run buildgit diff --checkChecklist