Skip to content

Addition of generic registry#612

Open
johnmehan wants to merge 4 commits into
estahn:mainfrom
johnmehan:main
Open

Addition of generic registry#612
johnmehan wants to merge 4 commits into
estahn:mainfrom
johnmehan:main

Conversation

@johnmehan
Copy link
Copy Markdown

Added a generic registry allowing k8s-image-swapper to be used with registries that use username/password.

@towolf
Copy link
Copy Markdown

towolf commented Nov 28, 2023

Also interested in having this in.

@towolf
Copy link
Copy Markdown

towolf commented Nov 29, 2023

@johnmehan we would like to deploy a simple local Docker registry without auth. Would that also be supported?

@InputObject2
Copy link
Copy Markdown

InputObject2 commented Dec 7, 2023

From my testing, it looks like this forces defining every source registry and will error out on any images are not from a registry in the list. It also forces adding creds to all of them. @johnmehan I've PR'd your repo with an additional modification to enable using anonymous copies (both on source and destination) and also without defining creds for everything.

@towolf While waiting for this to be merged eventually I pushed an image to inputobject2/k8s-image-swapper:v1.5.9-noauth that I'm using without issue in my homelab.

Added the ability to auth without creds and fixed forcing the source …
@johnmehan
Copy link
Copy Markdown
Author

@InputObject2 I've merged your changes. Thanks!

Comment thread pkg/config/config.go
registryClient registry.Client
imagePullSecretProvider secrets.ImagePullSecretsProvider
sourceRegistryClients []registry.Client
destinationRegistryClient registry.Client
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to targetRegistryClient to stay consistent with the config?

@InputObject2
Copy link
Copy Markdown

@estahn this PR might also close #29 and #30

@rattboi
Copy link
Copy Markdown
Contributor

rattboi commented Jun 1, 2024

@estahn would love to see this get merged. I think I'm going to need to build this w/ the PR and run my own container in the meantime.

@rattboi
Copy link
Copy Markdown
Contributor

rattboi commented Jun 17, 2024

hi @estahn , I'm curious if you've found time to review this.

@mrclrchtr
Copy link
Copy Markdown

I'm also interested in this change

@krx252525
Copy link
Copy Markdown

krx252525 commented Oct 9, 2024

Here's a rough draft of this branch rebased against the latest changes/dependabot updates: #819

@mittalsuraj18
Copy link
Copy Markdown

mittalsuraj18 commented Mar 13, 2025

Do we know when this will be merged @estahn ?
After the new changes regarding pull request that dockerhub has put up, this will help a lot so that we can authenticate with dockerhub with a single pro account while pulling images and then caching to our relevant aws ecr or gcp registries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants