go/writer: column-oriented parquet write buffer#4485
Draft
jacobmarble wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Switch the Parquet write buffer from row-major
[][]anyto column-major[]anyof typed slice pointers (*[]int64,*[]parquet.ByteArray, etc.) with a parallel[]int16definition-level slice. This avoids boxing a 3-word slice header on every append.Values are converted to their Parquet physical types by the
Writemethod instead of during the flush loop. This eliminates the transposition step and reduces GC pressure. It also exposes type conversion errors emitted bygetFooVal(val)at the same time.Parquet Variant types require two physical columns. This prepares the internal API to do that better.
Workflow steps:
n/a
Documentation links affected:
n/a
Notes for reviewers:
This is the simple part of #4471